Fix unmarshal values #788
Merged
Fix unmarshal values #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandenburger
force-pushed
the
fix-unmarshal-values
branch
2 times, most recently
from
7a09456 to
29681cf
Compare
Contributor
|
Double-checked the pipeline — the new test case has been executed and passed successfully. |
ryjones
force-pushed
the
fix-unmarshal-values
branch
from
29681cf to
fc1f7ef
Compare
munapower
approved these changes
Apr 10, 2025
Contributor
munapower
left a comment
munapower
left a comment
There was a problem hiding this comment.
At a high level the code looks good and Zac was able to verify that the test worked.
- adding a test case that tries submids a malicous key that might cause a null pointer dereferencing in `get_public_state_by_partial_composite_key`, which may crash the enclave Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
mbrandenburger
force-pushed
the
fix-unmarshal-values
branch
from
fc1f7ef to
57209ec
Compare
|
Hi @mbrandenburger, can I have a response on my report concerning this bug? it's been months! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a malicious key is used that might cause a null pointer dereferencing in
unmarshal_values, which may crash the enclave.